hi there,
is there a change to get ova working with the current trunk version of flowplayer ?
we are using the trunk version of flowplayer, because we are interrested at the bitrateselect plugin (the bwcheck plugin does not work well and seems to be deprecated).
kind regards,
harry
Hmmm... ok... thanks Harry for raising. I'll get looking into it...
I've logged an OVA ticket on this to help you track progress:
http://developer.longtailvideo.com/ova/ticket/323
Paul
hi paul,
i got the trunk versions running.
the following changes make them to work:
flowplayer.core:
Index: src/actionscript/org/flowplayer/model/ExtendableHelper.as
===================================================================
--- src/actionscript/org/flowplayer/model/ExtendableHelper.as (revision 722)
+++ src/actionscript/org/flowplayer/model/ExtendableHelper.as (working copy)
@@ -20,7 +20,6 @@
public function setProp(name:String, value:Object):void {
Assert.notNull(name, "the name of the property cannot be null");
- Assert.notNull(value, "the value of the property cannot be null");
if (!_customProperties) {
_customProperties = new Object();
flowplayer.common:
Index: src/actionscript/org/flowplayer/net/BitrateResource.as
===================================================================
--- src/actionscript/org/flowplayer/net/BitrateResource.as (revision 1723)
+++ src/actionscript/org/flowplayer/net/BitrateResource.as (working copy)
@@ -47,17 +47,19 @@
var i:int = 0;
- // sort the bitrateitems in ascording order before generating the list.
- var bitrates:Array = (clip.getCustomProperty("bitrates") as Array).sortOn(["bitrate"], Array.NUMERIC);
+ if(clip.getCustomProperty("bitrates"))
+ {
+ // sort the bitrateitems in ascording order before generating the list.
+ var bitrates:Array = (clip.getCustomProperty("bitrates") as Array).sortOn(["bitrate"], Array.NUMERIC);
+ for each(var props:Object in bitrates) {
+ var bitrateItem:BitrateItem = new PropertyBinder(new BitrateItem()).copyProperties(props) as BitrateItem;
- for each(var props:Object in bitrates) {
- var bitrateItem:BitrateItem = new PropertyBinder(new BitrateItem()).copyProperties(props) as BitrateItem;
+ bitrateItem.index = i;
- bitrateItem.index = i;
-
- streamingItems.push(bitrateItem);
- i++;
+ streamingItems.push(bitrateItem);
+ i++;
+ }
}
flowplayer.core:
Index: src/actionscript/org/flowplayer/model/Clip.as
===================================================================
--- src/actionscript/org/flowplayer/model/Clip.as (revision 723)
+++ src/actionscript/org/flowplayer/model/Clip.as (working copy)
@@ -677,11 +677,8 @@
[Value]
public function get cuepoints():Array {
var cues:Array = new Array();
- for each (var value:Object in _cuepoints) {
- var cues2:Array = value as Array;
- for each (var cue:Object in cues2) {
- cues.push(cue);
- }
+ for each (var cue:Object in _cuepoints) {
+ cues.push(cue);
}
return cues;
}
with the current trunk after a preroll ad the playlist stops and the play again button appears (the main video is skipped).
the changes in revision 703 seems to be the problem:
http://code.google.com/p/flowplayer-core/source/detail?r=703